Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cascading delete #15

Closed
dimitri-yatsenko opened this issue Aug 28, 2014 · 4 comments
Closed

cascading delete #15

dimitri-yatsenko opened this issue Aug 28, 2014 · 4 comments
Assignees
Labels

Comments

@dimitri-yatsenko
Copy link
Member

see dj.Relvar/del on the MATLAB side.

@dimitri-yatsenko dimitri-yatsenko changed the title cascading deletes cascading delete Aug 28, 2014
@dimitri-yatsenko dimitri-yatsenko added this to the Release v0.1 milestone Jun 15, 2015
eywalker added a commit to eywalker/datajoint-python that referenced this issue Jul 17, 2015
@eywalker
Copy link
Contributor

First pass version of cascading delete is now implemented. As far as I could test, it works appropriately. However, it is crucial that we add more tests for complex relational operation. In particular, we would need to add test cases for delete and combination of delete, restrict, and project.

I'll try adding test cases covering cascading as well as normal deletes hopefully within today.

@eywalker
Copy link
Contributor

There is a known bug in the cascading delete where restricted deletion on tables with multiple dependency to the source table may be incorrect. Fix will be implemented soon...

dimitri-yatsenko added a commit to dimitri-yatsenko/datajoint-python that referenced this issue Aug 4, 2015
@dimitri-yatsenko
Copy link
Member Author

mostly solved in e0aadc0.

There is one non-critical case when delete fails to cascade correctly, but this case has never happened in real schemas. This case only concerns multiple dependence paths through non-primary dependencies.

@eywalker
Copy link
Contributor

Yes, but the solution is known and thus there is no reason not to implement
the fix :)

On 5:24pm, Fri, Aug 14, 2015 Dimitri Yatsenko notifications@github.com
wrote:

mostly solved in e0aadc0
e0aadc0.

There is one non-critical case when delete fails to cascade correctly, but
this case has never happened in real schemas. This case only concerns
multiple dependence paths through non-primary dependencies.


Reply to this email directly or view it on GitHub
#15 (comment)
.

dimitri-yatsenko added a commit to dimitri-yatsenko/datajoint-python that referenced this issue Sep 14, 2015
dimitri-yatsenko pushed a commit to dimitri-yatsenko/datajoint-python that referenced this issue Sep 14, 2015
eywalker added a commit that referenced this issue Sep 18, 2015
Fix cascading delete under converging dependencies - issue #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants