.populate(reserve_jobs=True) to exclude error and ignore keys
#1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I was hoping this could be done without that initial query by simply keeping track how many calls have already been made. But the multiprocessing makes it difficult. |
dimitri-yatsenko
approved these changes
Dec 1, 2022
|
Please update the |
Thanks, CHANGELOG updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, DataJoint's
.populate()call with specifiedmax_callsargument does not achieve the expected behavior.For example, if there are 10 keys remaining to be populated and of those 10, 3 are "error" and 2 are "ignore", and if those 5 error/ignore keys are top of the list, calling
Table.populate(reserve_jobs=True, max_calls=3)will do nothing. The expected behavior should be that, with the same call, DataJoint should know to fetch backkeysto be worked on but excluding those that areerror/ignore. In the example above, this should be just the 5 remaining, not all 10, and from those keys, callmake()on 3 of them.This PR fixes the described issue.