Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for insert CSV #1067

Merged
merged 5 commits into from
Dec 16, 2022
Merged

Add support for insert CSV #1067

merged 5 commits into from
Dec 16, 2022

Conversation

CBroz1
Copy link
Contributor

@CBroz1 CBroz1 commented Dec 9, 2022

  • For insert method, check if object is pathlib.Path. If so, load as comma-delimited data
  • Modify test to run this method
  • Pass tests
  • Edit root README to reflect change from sphinx to mkdocs
  • Add documentation for new feature (add inserting various data types)

@CBroz1 CBroz1 marked this pull request as ready for review December 13, 2022 15:58
@dimitri-yatsenko
Copy link
Member

Looks great! Thanks! Please update the CHANGELOG and we'll merge.

Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also accept the filepath in the form of a str as well as pathlib.Path?

@CBroz1
Copy link
Contributor Author

CBroz1 commented Dec 13, 2022

Please update the CHANGELOG and we'll merge.

Updated

Would it make sense to also accept the filepath in the form of a str as well as pathlib.Path?

My thought process was that a pathlib object is unambiguous. But I can adjust if you prefer accepting filepaths as strings. Is there any case where we would want to accept data as a string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants