Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated features + small fixes #1073

Merged

Conversation

guzman-raphael
Copy link
Collaborator

@guzman-raphael guzman-raphael commented Feb 9, 2023

  • Fixed - Convert lingering prints by replacing with logs PR #1073

  • Changed - table.progress() defaults to no stdout PR #1073

  • Changed - table.describe() defaults to no stdout PR #1073

  • Deprecated - table._update() PR #1073

  • Deprecated - old-style foreign key syntax PR #1073

  • Deprecated - dj.migrate_dj011_external_blob_storage_to_dj012() PR #1073

  • Other items:

    • Optimize database healthcheck in tests
    • Fix bug in test_drop test

@guzman-raphael guzman-raphael marked this pull request as ready for review February 9, 2023 16:44
@guzman-raphael guzman-raphael mentioned this pull request Feb 9, 2023
7 tasks
@@ -504,14 +504,14 @@ def test_date():
F.insert1((2, "2019-09-25"))

new_value = None
(F & "id=2")._update("date", new_value)
F.update1(dict((F & "id=2").proj().fetch1(), date=new_value))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
F.update1(dict((F & "id=2").proj().fetch1(), date=new_value))
F.update1(dict((F & "id=2").fetch1("KEY"), date=new_value))

@dimitri-yatsenko dimitri-yatsenko merged commit f28a3b9 into datajoint:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants