Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attribute type: implement #627 #639

Merged
merged 23 commits into from
Sep 16, 2019

Conversation

dimitri-yatsenko
Copy link
Member

Implement user-defined attribute types as described in #627

@coveralls
Copy link

coveralls commented Aug 4, 2019

Coverage Status

Coverage decreased (-0.2%) to 92.029% when pulling bb2e5fe on dimitri-yatsenko:custom-attribute-type into fc21b5c on datajoint:dev.

@dimitri-yatsenko dimitri-yatsenko marked this pull request as ready for review August 5, 2019 08:29
@guzman-raphael
Copy link
Collaborator

@dimitri-yatsenko Can you increase the version (e.g. 0.12.dev-attr-adpt1) and also resolve the merge conflict with heading.py?

@ixcat
Copy link
Contributor

ixcat commented Sep 12, 2019

where's the docs?

@ixcat
Copy link
Contributor

ixcat commented Sep 13, 2019

Was being a bit 'jesty' here since I'm working on docs for v0.12..

But: more generally should we require documentation upon adding a new feature?

aka the 'feature' is always 'code + user documentation'

this forces documentation to always be current, and also forces clarifying features since one has to be able to explain them coherently in human language. aka documentation is a 'human unit test'

@dimitri-yatsenko
Copy link
Member Author

Yes, we should update the documentation along with releases. Attribute Adapters are an alpha feature for a specific lab and are not going to be officially supported until 0.12.1 at least. So no documentation yet.

@guzman-raphael guzman-raphael merged commit 89af1ee into datajoint:dev Sep 16, 2019
@dimitri-yatsenko dimitri-yatsenko deleted the custom-attribute-type branch September 22, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants