Workaround for now missing setuptools which are used in setup.py #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
added
release
|
Code Climate has analyzed commit 67fa558 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 24 24
Lines 1133 1133
=======================================
Hits 1073 1073
Misses 60 60 ☔ View full report in Codecov by Sentry. |
jwodder
reviewed
Jan 17, 2024
| @@ -27,6 +27,7 @@ jobs: | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
| pypi-token: ${{ secrets.PYPI_TOKEN }} | |||
| pre-tag: | | |||
| pip install setuptools # needed for setup.py --version | |||
There was a problem hiding this comment.
@yarikoptic This is for setup.py --name, not setup.py --version (which you're not doing).
There was a problem hiding this comment.
dang... right... damn suggestions in pycharm... will all be gone with hardcoding...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #254