Various fixes to get basic functionality running on windows #1567
Conversation
|
Not so simple, is it.... |
|
is there an immediate demand to make our beast work on windows? |
|
What does the grand proposal say? ;-)
…On Jun 13, 2017 05:03, "Yaroslav Halchenko" ***@***.***> wrote:
is there an immediate demand to make our beast work on windows?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1567 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIVH5aLJjW1ZV_JkhOHttBYSPjPHAI_ks5sDejLgaJpZM4N3e8E>
.
|
|
NFS failure due to known issue unrelated to these changes. |
Codecov Report
@@ Coverage Diff @@
## master #1567 +/- ##
==========================================
- Coverage 85.28% 85.27% -0.01%
==========================================
Files 253 253
Lines 29181 29197 +16
==========================================
+ Hits 24886 24899 +13
- Misses 4295 4298 +3
Continue to review full report at Codecov.
|
|
Before this is merged, it needs manual confirmation that it actually works on windows. It should not break other platforms, but the fixes I made are done completely blind -- hope to get to testing tonight. |
|
if we are supporting windows now, we should establish CI on it, e.g. using appveyor: here is an example https://github.com/duecredit/duecredit/blob/master/appveyor.yml . |
|
re windows CI: let's wait till at least one test ever passed during manual invocation.... |
|
@bpoldrack @yarikoptic new screenshot -- major progress. In |
|
If the tests pass, I'll merge this. |
|
re downloader -- "not sure". that ds000001 could use indeed datalad-archives, but there is also urls per each file which should be just fetched by git-annex curl/wget... you might want to see more of the traceback -- SET DATALAD_EXC_STR_TBLIMIT=20 or so? ;) |
There was a problem hiding this comment.
in general -- good and worthwhile merging if tests pass right away... but not sure on SSHManager handling as if there is for sure no ssh on windows e.g. http://sshwindows.sourceforge.net/ or may be smth else... not sure though how git/annex handle all the ssh interactions
| if win_split[0] and win_split[1]: | ||
| # OMG we got something from windows | ||
| lgr.log(5, "Detected file ri") | ||
| return TYPES['file'] |
There was a problem hiding this comment.
not necessarily from windows -- could be some local masocist ;-)
hopa:~
$> touch c:\\bugi\dugi
2 19687.....................................:Tue 13 Jun 2017 04:53:35 PM EDT:.
hopa:~
$> ls -ld c:\\bugi\dugi
-rw------- 1 yoh yoh 0 Jun 13 16:53 c:\\bugidugi
but the conclusion holds ;)
| ssh_manager = SSHManager() | ||
| atexit.register(ssh_manager.close, allow_fail=False) | ||
| else: | ||
| ssh_manager = None |
There was a problem hiding this comment.
IIRC There could be a cmdline ssh on Windows -- why should we just rule it out at once?
Biggest pieces is to make the global SSHManager optional.
Some proof: