Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relations in group controls #749

Merged
merged 32 commits into from
Apr 9, 2024

Conversation

mournfulCoroner
Copy link
Contributor

@mournfulCoroner mournfulCoroner commented Mar 11, 2024

Related to datalens-tech/datalens#89

  • set up the correct operation of links in group selectors (include migration links from old selectors to new)
  • add the ability to select the current item in the group selector relations dialog
  • a new way of displaying debug info for group selectors
  • new system for counting loaded selectors in group selectors
  • change naming of subitems in groups from items to group

@mournfulCoroner mournfulCoroner force-pushed the CHARTS-9094-Support-relations-in-group-controls branch from 4a1ad26 to 6592578 Compare March 11, 2024 13:18
Copy link
Contributor

github-actions bot commented Mar 11, 2024

E2E Report is ready.

@mournfulCoroner mournfulCoroner force-pushed the CHARTS-9094-Support-relations-in-group-controls branch from 6592578 to 38cae7c Compare March 11, 2024 13:34
Copy link
Contributor

github-actions bot commented Mar 11, 2024

📦 Statoscope quick diff with main-branch:

⏱ Build time: -606 ms (-0.39%)

⚖️ Initial size: 8.07 kb (0.33%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

package.json Outdated Show resolved Hide resolved
@robot-charts
Copy link
Collaborator

i18n-check

The following components have not been translated

component.dialog-relations.view (ru)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@robot-charts
Copy link
Collaborator

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

…hub.com:datalens-tech/datalens-ui into CHARTS-9094-Support-relations-in-group-controls
@robot-charts
Copy link
Collaborator

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

@robot-charts
Copy link
Collaborator

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

@robot-charts
Copy link
Collaborator

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

* Translated using Weblate (Russian)

Currently translated at 100.0% (53 of 53 strings)

Translation: DataLens/component.dialog-relations.view__749
Translate-URL: https://weblate.gravity-ui.com/projects/datalens/charts-9094-support-relations-in-group-controls-749/component-dialog-relations-view-749/ru/

* Translated using Weblate (English)

Currently translated at 100.0% (53 of 53 strings)

Translation: DataLens/component.dialog-relations.view__749
Translate-URL: https://weblate.gravity-ui.com/projects/datalens/charts-9094-support-relations-in-group-controls-749/component-dialog-relations-view-749/en/

---------

Co-authored-by: Darya Tikhonova <tihonova-d@yandex-team.ru>
Co-authored-by: Taya Leutina <leutinatasya@yandex-team.ru>
@robot-charts
Copy link
Collaborator

i18n-check

The following components have not been translated

component.dialog-relations.view (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@mournfulCoroner mournfulCoroner merged commit 03c20c0 into main Apr 9, 2024
8 checks passed
@mournfulCoroner mournfulCoroner deleted the CHARTS-9094-Support-relations-in-group-controls branch April 9, 2024 12:20
melikhov-dev pushed a commit that referenced this pull request Apr 26, 2024
* Support relations in group controls

* Support multicontrol relations

* Rename items to group

* Support migration from old selectors

* Up dashkit@6.9.0

* Merge branch 'main' into CHARTS-9094-Support-relations-in-group-controls

* fixes

* Discard changes to .github/workflows/statoscope_tests.yml

* Fixes after resolving conflicts

* Fix formatting

* review fixes

* Fix namespace lost

* Fix error control and dialog relations

* Fix dialog relations with errors

* Fix tests

* Fix relations behavior

* Fix saving selector

* Translations update from Weblate Gravity for PR #749 (#787)

* Translated using Weblate (Russian)

Currently translated at 100.0% (53 of 53 strings)

Translation: DataLens/component.dialog-relations.view__749
Translate-URL: https://weblate.gravity-ui.com/projects/datalens/charts-9094-support-relations-in-group-controls-749/component-dialog-relations-view-749/ru/

* Translated using Weblate (English)

Currently translated at 100.0% (53 of 53 strings)

Translation: DataLens/component.dialog-relations.view__749
Translate-URL: https://weblate.gravity-ui.com/projects/datalens/charts-9094-support-relations-in-group-controls-749/component-dialog-relations-view-749/en/

---------

Co-authored-by: Darya Tikhonova <tihonova-d@yandex-team.ru>
Co-authored-by: Taya Leutina <leutinatasya@yandex-team.ru>

* Fix multiple controls var

* Fix aliases bug

* Fix lost selectorParameters

* Fix more bugs

* Remove unused import

---------

Co-authored-by: Georgy Malkov <malkovgv@yandex-team.ru>
Co-authored-by: WeblateGravity <150622038+WeblateGravity@users.noreply.github.com>
Co-authored-by: Darya Tikhonova <tihonova-d@yandex-team.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants