Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Authentication #6

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[feature] Authentication #6

wants to merge 17 commits into from

Conversation

marinofranz
Copy link
Member

@marinofranz marinofranz commented Jan 15, 2023

Context

This PR is for authentication functionality including account creations (sign ups), and account access (sign ins). The pages are intended to contain:

  • /login - Returning users, sign ins
    • Themes - Light & Dark mode
    • Back Button - Go back to the previous page
    • Action Button - Login button which is animated with an ease-in/ease-out
    • Waving Emoji - Animated waving emoji hand which goes left and right; i.e., waves
    • Mobile Responsiveness - Page should function as expected on a mobile layout
    • Captcha - Verify that the request was made by a real user
    • Functionality - Make the page actually query API endpoints and work
      • GitHub OAuth
      • Internal auth API queries
      • Handling invalid credentials
  • /register - New users, sign ups
    • Captcha - Verify that the request was made by a real user
    • Functionality - Make the page actually query API endpoints and work
      • GitHub OAuth
      • Internal create API queries

In this PR

@marinofranz marinofranz added the enhancement New feature or request label Jan 15, 2023
@marinofranz marinofranz self-assigned this Jan 15, 2023
@vercel
Copy link

vercel bot commented Jan 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
datalink ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 11:30PM (UTC)

Copy link
Member

@CompeyDev CompeyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks perfect!

@CompeyDev CompeyDev changed the title feat: auth pages [feature] Authentication Jan 15, 2023
Copy link
Member

@CompeyDev CompeyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the following into account.

src/pages/login.tsx Show resolved Hide resolved
@CompeyDev CompeyDev marked this pull request as ready for review January 19, 2023 07:46
@marinofranz
Copy link
Member Author

This commit implements responsive design to the login page, a position for the change theme button is still undetermined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants