Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect as a named user when creating the first API key #190

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Apr 27, 2021

Fixes #188

This enables:

seqcli apikey create -t First --token="yourtokenhere" --connect-username=admin --connect-password=password --permissions="Read,Write,Setup"

Some form of testing still outstanding. ✔️

@nblumhardt nblumhardt marked this pull request as ready for review April 28, 2021 04:57
@nblumhardt
Copy link
Member Author

Alrighty, ready to go!

I think the main thing that warrants explanation is the choice of --connect-username= and --connect-password= in preference over --username and --password: we have several API endpoints that take usernames and passwords as arguments.

In those cases we may still at some point want to separately control the username and password used when making the connection to the API.

E.g. if we ended up supporting username/password auth everywhere, you'd hit this conflict when creating another user, or when configuring credentials for a NuGet feed.

@codedevote
Copy link

Wow, great news, Nick. I was looking at the tests yesterday and came back here to ask whether I can try to write an end-to-end test, just to find that you already finished it 🥇 If there is still anything I can help with, feel free to reach out.

@nblumhardt
Copy link
Member Author

Thanks, Florian 👍

@nblumhardt nblumhardt merged commit 8c77d21 into datalust:dev Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to create "first api key" to use for any further authentication
2 participants