Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first draft of Airflow documentation #128

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Add first draft of Airflow documentation #128

merged 4 commits into from
Dec 17, 2020

Conversation

hancush
Copy link
Member

@hancush hancush commented Oct 9, 2020

Overview

This PR adds documentation to capture our team knowledge and best practices for Airflow.

Co-authored by @jeancochrane and @fatima3558!

Handles #88

Testing Instructions

  • View the rendered Markdown and confirm that it looks good, and that the links resolve.
  • Review the copy and ensure that it is clear and consistent.

Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
Co-authored-by: Fatima Gomez <fatima3558@users.noreply.github.com>
@hancush hancush mentioned this pull request Oct 9, 2020
etl/airflow.md Show resolved Hide resolved
Copy link
Member Author

@hancush hancush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, @fatima3558 and @jeancochrane! Thank you both so much for drafting your respective sections so quickly. I left some comments inline and tagged you in ones relevant to you. I also made some formatting suggestions that I'll batch and commit myself. Will keep an eye out for comments on my sections.

etl/airflow.md Outdated Show resolved Hide resolved
etl/airflow.md Outdated Show resolved Hide resolved
etl/airflow.md Outdated Show resolved Hide resolved
etl/airflow.md Show resolved Hide resolved
etl/airflow.md Outdated Show resolved Hide resolved
etl/airflow.md Show resolved Hide resolved
etl/airflow.md Show resolved Hide resolved
etl/airflow.md Outdated Show resolved Hide resolved
etl/airflow.md Outdated Show resolved Hide resolved
etl/airflow.md Show resolved Hide resolved
hancush and others added 2 commits October 22, 2020 12:37
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
@fgomez828
Copy link
Contributor

@hancush these changes look good to me! I have some pending changes that I'm going to include to the Basic Concepts section, which I'd appreciate another pair of eyes on before merging this in

Copy link
Contributor

@fgomez828 fgomez828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as your changes, @hancush , they look good to me!

@fgomez828 fgomez828 merged commit 88cd709 into master Dec 17, 2020
@hancush hancush deleted the team/airflow branch July 14, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants