-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed layers, simplified architectures #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dom for this first cleanup. I haven't run the code as it is mainly a cleaning and refactoring PR.
I am often picky and opinionated when reviewing so feel free to disagree or comment more on my reviews.
The platform also switched to black
as a Python code formatted. There is a GA setup to check each commit has formatted code (see https://github.com/invivoai/goli/blob/master/.github/workflows/lint.yml#L31). black
is pretty standard and you should be able to configure it on your favourite IDE.
3ebeba1
to
e810a5b
Compare
This pull-request has a lot of progress in the refactoring of the code, but there is still a lot to do.
The examples will no longer run after the merging, but I want to avoid pull-requests too large, so I think we can still go forward with the PR and do the remaining changes in another PR.