Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished alpha version #34

Merged
merged 25 commits into from
Mar 24, 2021
Merged

Finished alpha version #34

merged 25 commits into from
Mar 24, 2021

Conversation

DomInvivo
Copy link
Collaborator

No description provided.

@DomInvivo DomInvivo requested a review from hadim March 23, 2021 01:58
@DomInvivo
Copy link
Collaborator Author

@hadim I basically fixed everything to make it enough for a first alpha release. Everything works as expected, except a few issues with the GPU and early stopping.

Please review the PR as soon as possible.

Copy link
Contributor

@hadim hadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few comments below.

goli/data/datamodule.py Outdated Show resolved Hide resolved
goli/data/datamodule.py Outdated Show resolved Hide resolved
goli/data/datamodule.py Outdated Show resolved Hide resolved
goli/trainer/predictor.py Outdated Show resolved Hide resolved
goli/trainer/predictor.py Outdated Show resolved Hide resolved
goli/trainer/predictor.py Outdated Show resolved Hide resolved
goli/trainer/predictor.py Show resolved Hide resolved
@DomInvivo DomInvivo merged commit c0c2384 into master Mar 24, 2021
@hadim hadim deleted the pl branch March 24, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants