-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable wandb by default + complete integration tests #434
Conversation
Codecov Report
@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 64.74% 65.41% +0.66%
==========================================
Files 89 89
Lines 8215 8218 +3
==========================================
+ Hits 5319 5376 +57
+ Misses 2896 2842 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Cas Wognum <caswognum@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor changes only
graphium/cli/train_finetune.py
Outdated
elif wandb_cfg is not None: | ||
wandb.init( | ||
entity=wandb_cfg["entity"], | ||
project=wandb_cfg["project"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will allow to pass more than just the entity or the project.
elif wandb_cfg is not None: | |
wandb.init( | |
entity=wandb_cfg["entity"], | |
project=wandb_cfg["project"], | |
elif wandb_cfg is not None: | |
wandb.init( | |
config=cfg, | |
**wandb_cfg |
# config is relative to a module | ||
cfg = hydra.compose( | ||
config_name="main", | ||
overrides=[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also override
trainer.trainer.check_val_every_n_epoch = 1
trainer.trainer.precision = 32, # perhaps you can make this 32 for CPU and 16 for IPU
Changelogs