Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_ipu.yml #453

Merged
merged 13 commits into from
Sep 1, 2023
Merged

Update test_ipu.yml #453

merged 13 commits into from
Sep 1, 2023

Conversation

s-maddrellmander
Copy link
Contributor

Removing the last section in the IPU test
There are tests failing that aren't causing the action to flag as failed...

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

Removing the last section in the IPU test
There are tests failing that aren't causing the action to flag as failed...
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #453 (bb30b82) into main (0d24634) will increase coverage by 7.23%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   64.62%   71.85%   +7.23%     
==========================================
  Files          93       93              
  Lines        8423     8422       -1     
==========================================
+ Hits         5443     6052     +609     
+ Misses       2980     2370     -610     
Flag Coverage Δ
unittests 71.85% <100.00%> (+7.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)

@s-maddrellmander s-maddrellmander marked this pull request as ready for review September 1, 2023 10:46
tests/test_training.py Outdated Show resolved Hide resolved
@s-maddrellmander s-maddrellmander merged commit 3346110 into main Sep 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants