Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline integration + Virtual Nodes Edges bug fix #457

Merged
merged 11 commits into from
Sep 5, 2023

Conversation

s-maddrellmander
Copy link
Contributor

@s-maddrellmander s-maddrellmander commented Sep 4, 2023

Changelogs

  • Stitching the accelerator kwargs into the model
  • Found + fixed a bug that meant edges wouldn't work with the virtual nodes
  • Added a function to recursively check for the edge out dim in the GNN layer kwargs - preserves previous functionality for simple layers and adds functionality for more complex layers.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #457 (20434b6) into main (fa5becc) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head 20434b6 differs from pull request most recent head daf011c. Consider uploading reports for the commit daf011c to get more accurate results

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   71.85%   71.84%   -0.02%     
==========================================
  Files          93       93              
  Lines        8422     8436      +14     
==========================================
+ Hits         6052     6061       +9     
- Misses       2370     2375       +5     
Flag Coverage Δ
unittests 71.84% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)

Copy link
Collaborator

@kerstink-GC kerstink-GC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@s-maddrellmander s-maddrellmander changed the title Pipeline integration Pipeline integration + Virtual Nodes Edges bug fix Sep 5, 2023
@s-maddrellmander s-maddrellmander merged commit 41a1172 into main Sep 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants