Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving extract folder name conflicts #5450

Merged
merged 1 commit into from May 2, 2019
Merged

Resolving extract folder name conflicts #5450

merged 1 commit into from May 2, 2019

Conversation

nvarscar
Copy link
Contributor

@nvarscar nvarscar commented May 1, 2019

Type of Change

  • Bug fix (non-breaking change, fixes [Bug] Update-DbaInstance uses the same folder to extract the files #5447 )
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Fix the issue

Approach

Adding random guids to the folder name every time

Commands to test

Screenshots

Learning

@potatoqualitee potatoqualitee merged commit fb3692d into dataplat:development May 2, 2019
@potatoqualitee
Copy link
Member

fabulous, thank you @nvarscar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Update-DbaInstance uses the same folder to extract the files
2 participants
@nvarscar @potatoqualitee