Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure tests are run according to pester.groups #8160

Merged

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Feb 9, 2022

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Make sure we run only tests that are safe to run on appveyor. @andreasjordan noticed when running #8159 that a test was invoked even if it is explicitely disabled via pester.groups.ps1.
This was because the dependency tracking that kicks in when tests are filtered out by the magic keyword (do whatever) considered the disabled when picking up the main tests, but not all of the dependencies. This fix refilters the list AFTER picking up the dependent tests.

Screenshots

Before
image

After
image

@potatoqualitee
Copy link
Member

Thank you! All tests ran the expected amount of time, so this is working. Appreciate it, Niph 🇮🇹

@potatoqualitee potatoqualitee merged commit a0a9bd8 into dataplat:development Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants