Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Get|Start|Stop|Restart]-DbaService - Add parameter SqlInstance #8159

Merged
merged 3 commits into from Feb 9, 2022
Merged

[Get|Start|Stop|Restart]-DbaService - Add parameter SqlInstance #8159

merged 3 commits into from Feb 9, 2022

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes Make DbaService commands use uniform param for 'SqlInstance' #8104 )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Approach

Commands to test

Screenshots

Learning

@andreasjordan andreasjordan changed the title Get-DbaService - Add parameter SqlInstance [Get|Start|Stop|Restart]-DbaService - Add parameter SqlInstance Feb 8, 2022
@potatoqualitee
Copy link
Member

I like this too @nvarscar can you please review?

@niphlod niphlod mentioned this pull request Feb 9, 2022
Merged
10 tasks
@nvarscar nvarscar self-requested a review February 9, 2022 16:21
nvarscar
nvarscar approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@nvarscar nvarscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this looks good. Renaming parameters doesn't seem feasible after the discussion in the related issue.

@potatoqualitee
Copy link
Member

sweet as heck! thank you both 🙇🏼

@potatoqualitee potatoqualitee merged commit aeaea51 into development Feb 9, 2022
@potatoqualitee potatoqualitee deleted the GetDbaService_SqlInstance branch February 9, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvarscar nvarscar nvarscar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make DbaService commands use uniform param for 'SqlInstance'
3 participants
@andreasjordan @potatoqualitee @nvarscar