-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: format errors #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry Yannick, not sure what happened yesterday ... trying to do 17 things at once! |
…ssign, remove { } brackets as cause issues with cli
Hi Yannick, following your comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to master, there are conflicts in the NAMESPACE.
27fed3e
to
08e9f1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are introducing a circular dependency by importing DSLite. You could move the tests to the DSLite package instead?
Implement two main changes:
return_error
todatashield.assign
functions, giving the option either to immediately return errors or to store them to be accessible with a call todatashield.errors
Note: tests written for
datashield.assign.expr
; however I was unable to create errors with eitherdatashield.assign.table
ordatashield.assign.resource
. If you have code which will do this tell me and I'll add tests.