feat: format errors #21
Conversation
There was a problem hiding this comment.
Not tested yet, please fix dependencies and documentation. Also I expect the man folder to be updated. In case you do not know how to do it in Rstudio, make sure in the project options that all the boxes are checked:
so that documentation is generated at check time.
R/datashield.assign.R
Outdated
| .checkLastErrors() | ||
| if(return_errors == TRUE){ | ||
| cli_text() | ||
| cli_alert_warning("Error: There are some DataSHIELD errors ") |
There was a problem hiding this comment.
What happens when the execution is not in a CLI context, like a batch script execution?
There was a problem hiding this comment.
Do you mean eg calling datashield.assign.expr in a loop? Or you had something else in mind?
There was a problem hiding this comment.
No, I mean when there is no command line, like when executing code with Rscript.
Sorry Yannick, not sure what happened yesterday ... trying to do 17 things at once! |
…ssign, remove { } brackets as cause issues with cli
|
Hi Yannick, following your comments:
|
There was a problem hiding this comment.
Please add .DS_Store to .gitignore and .Rbuildignore (thank you Apple for the noise).
| #' @importFrom purrr map | ||
| #' @importFrom stringr str_replace_all | ||
| .remove_curly_brackets <- function(errors) { | ||
| errors <- errors %>% map(~str_replace_all(.x, "\\{", "(")) |
There was a problem hiding this comment.
Try to minimize the package dependencies. I don't think you need all the fancy packages dplyr, purr and stringr for that function, just go the plain old R way:
# Replace all curly brackets with parentheses
output_string <- gsub("\\{", "(", input_string)
output_string <- gsub("\\}", ")", output_string)
Implement two main changes:
return_errortodatashield.assignfunctions, giving the option either to immediately return errors or to store them to be accessible with a call todatashield.errorsNote: tests written for
datashield.assign.expr; however I was unable to create errors with eitherdatashield.assign.tableordatashield.assign.resource. If you have code which will do this tell me and I'll add tests.