Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automount option #354

Closed
fcollonval opened this issue May 6, 2024 · 1 comment · Fixed by #361
Closed

Automount option #354

fcollonval opened this issue May 6, 2024 · 1 comment · Fixed by #361
Labels
bug Something isn't working dataset Issues related to the Dataset and DatasetInternal Operator

Comments

@fcollonval
Copy link

fcollonval commented May 6, 2024

The current behavior is to mount a dataset in all containers - including init containers.

It is also possible to specify a custom mount point as in that example. But the default mount point is also created (see pod description below).

Would you consider adding a new label or a new value for the useas label (something like manualMount) to defer the mount point definition to the datashim consumer?

From current pod description:

Start Time:       Mon, 06 May 2024 11:02:53 +0200
Labels:           dataset.0.id=dataset-images-content
                  dataset.0.useas=mount
                  ...
Annotations:      ...
Status:           Running
Init Containers:
  init-container-1:
    ...
    Mounts:
      /mnt/datasets/dataset-images-content from dataset-images-content (rw)
  init-container-2:
    ...
    Mounts:
      /mnt/datasets/dataset-images-content from dataset-images-content (rw)
Containers:
  container-1:
    ...
    Mounts:
      /mnt/datasets/dataset-images-content from dataset-images-content (rw)
  container-2:
    Mounts:
      ...
      /mnt/datasets/dataset-images-content from dataset-images-content (rw)
      /var/data/images from dataset-images-content (rw)
Conditions:
  Type              Status
  Initialized       True 
  Ready             True 
  ContainersReady   True 
  PodScheduled      True 
Volumes:
  ...
  dataset-images-content:
    Type:        PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:   dataset-images-content
    ReadOnly:    false

@srikumar003
Copy link
Collaborator

@fcollonval You've spotted a bug in the operator. If the mount point is overriden in the podspec as in the example, then the default mount points should not be created. Will issue a fix soon

@srikumar003 srikumar003 added bug Something isn't working dataset Issues related to the Dataset and DatasetInternal Operator labels May 6, 2024
srikumar003 added a commit to srikumar003/datashim that referenced this issue May 21, 2024
Signed-off-by: SRIKUMAR VENUGOPAL <srikumarv@ie.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dataset Issues related to the Dataset and DatasetInternal Operator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants