Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise Optional[str] constructor parameters when it does not make sense #186

Closed
hemidactylus opened this issue Jan 31, 2024 · 0 comments · Fixed by #187
Closed

Revise Optional[str] constructor parameters when it does not make sense #186

hemidactylus opened this issue Jan 31, 2024 · 0 comments · Fixed by #187
Assignees
@erichare

Comments

@hemidactylus
Copy link
Collaborator

Why token: Optional[str] and api_endpoint likewise when then it's a ValueError not passing it? Probably a leftover of old times, can be made more adherent to expectations to help developers.
@erichare erichare self-assigned this Jan 31, 2024
erichare added a commit that referenced this issue Jan 31, 2024
@erichare
Fix #186 - token and api endpoint not optional
c5ad797
@erichare erichare linked a pull request Jan 31, 2024 that will close this issue
Fix #186 - token and api endpoint not optional #187
Merged
erichare added a commit that referenced this issue Feb 1, 2024
@erichare
Fix #186 - token and api endpoint not optional (#187)
d7c91f1 
* Fix #186 - token and api endpoint not optional

* Update test config

* Clean param specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erichare erichare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #186 - token and api endpoint not optional datastax/astrapy
2 participants
@erichare @hemidactylus