Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configuration value for Reuben to use #139

Closed
wants to merge 1 commit into from

Conversation

mieslep
Copy link
Collaborator

@mieslep mieslep commented Jun 1, 2022

No description provided.

@@ -84,6 +84,9 @@
#
#issueId="XXX-6"

# The MD5 checksum of the provided .key file
#keyMD5sum=
Copy link
Member

@michaelsembwever michaelsembwever Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generating this shouldn't be up to Reuben.

that should be done in this repo in the top-level https://github.com/datastax/diagnostic-collection/blob/master/Makefile

e.g change

ifdef COLLECTOR_SECRETSMANAGER_KEY
ifdef COLLECTOR_SECRETSMANAGER_SECRET
	@sed -i.bak 's/encrypt_uploads=.*/encrypt_uploads=\"true\"/' collector/collector.conf
endif
endif

to

ifdef COLLECTOR_SECRETSMANAGER_KEY
ifdef COLLECTOR_SECRETSMANAGER_SECRET
	@sed -i.bak 's/encrypt_uploads=.*/encrypt_uploads=\"true\"/' collector/collector.conf
	$(eval KEY_FILE_NAME := $(shell echo $(subst /,-,$(ISSUE))_secret.key))
	@sed -i.bak 's/#keyMD5sum=.*/keyMD5sum==\"$$(md5sum $KEY_FILE_NAME)\"/' collector/collector.conf
endif
endif

@michaelsembwever
Copy link
Member

can we close this (as 'wont do')?

@michaelsembwever
Copy link
Member

Closing. (Also note, there's no public knowledge of Reuben…)

@michaelsembwever michaelsembwever deleted the issue/130-part1 branch January 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants