Fix annotation parser ordering #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies annotation parser comparator to order fields to normal (growing) order, accordingly to passed parameter at keys annotations (@ClusteringColumn(0), @ClusteringColumn(1), ...).
|
Many thanks for catching this. I've added a unit test and slightly changed the error message, which was not always clear IMHO. |
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
Move builder(ConnectionFactoryOptions connectionFactoryOptions) from PostgresqlConnectionConfiguration to PostgresqlConnectionFactoryProvider to resolve the class cycle. [apache#210]
Sfurti-yb
pushed a commit
to yugabyte/cassandra-java-driver
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies annotation parser comparator to order fields to normal (growing) order, accordingly to passed parameter at keys annotations (@ClusteringColumn(0), @ClusteringColumn(1), ...).