-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made various changes to cleanup retrieval #362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epinzur
changed the title
made various changes to improve retrieval performance
DRAFT: made various changes to improve retrieval performance
Apr 3, 2024
nicoloboschi
suggested changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general
I think we should improve the error handling
epinzur
force-pushed
the
colbert-retriever-improvements
branch
from
April 16, 2024 20:29
7342320
to
83e5f29
Compare
epinzur
changed the title
DRAFT: made various changes to improve retrieval performance
made various changes to improve retrieval performance
Apr 16, 2024
epinzur
changed the title
made various changes to improve retrieval performance
made various changes to cleanup retrieval
Apr 16, 2024
Co-authored-by: Nicolò Boschi <boschi1997@gmail.com>
epinzur
force-pushed
the
colbert-retriever-improvements
branch
from
April 18, 2024 21:42
6f8d18d
to
d632492
Compare
epinzur
force-pushed
the
colbert-retriever-improvements
branch
from
April 18, 2024 21:48
e8e8534
to
4ea9f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made a bunch of changes that generally make sure our ColBERT retrieval code interacts nicely with Cassandra (doesn't overload the database when making queries).
There is little change in retrieval latency with these changes running on CPU.
wrapped async calls to cassandra inside a
ThreadPoolExecutor
.max_casandra_workers
works the best.automatically dropping down to half-precision when calculating chunk scores, if running on GPU and the GPU supports it.
is_fp16
flag is getting set toTrue
on boxes with CUDA support.