Static files for values #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inercia
force-pushed
the
inercia/extra_labels
branch
from
a5d7332
to
64dedfc
Compare
inercia
commented
Apr 15, 2020
| @@ -2,8 +2,8 @@ | |||
|
|
|||
| k3d_prov_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)" | |||
There was a problem hiding this comment.
Ignore changes in this file: just formatting.
inercia
force-pushed
the
inercia/extra_labels
branch
from
64dedfc
to
1c0e0bc
Compare
|
CI will fail until a new release of the Helm chart is available. |
inercia
force-pushed
the
inercia/extra_labels
branch
from
1c0e0bc
to
1c65815
Compare
* Load files for values from some predefined locations. The Operator will use these values files for setting Helm values before installing the Chart. * Static values files as ConfigMaps, with different `deploymentTool` for the manifest and for the Operator Helm chart. * Static value file added in the image that is deployed to Azure, with a specific `deploymentTool` for Azure. Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
inercia
force-pushed
the
inercia/extra_labels
branch
from
1c65815
to
e09fc63
Compare
|
A new Helm chart has been published and CI is passing. Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploymentToolfor the manifest and for the Operator Helm chart.deploymentToolfor Azure.Notes for reviewers
k3d.shhas suffered some re-formatting. Please ignore.