Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derror: Properly unwrap for Go 1.13 errors.Is and errors.As #27

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

LukeShu
Copy link
Contributor

@LukeShu LukeShu commented Aug 7, 2021

derror predates that, so of course it's using the old github.com/pkg/errors mechanism and not the Go 1.13 mechanism. Update it to work with both!

Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit it!

@LukeShu LukeShu merged commit f47bfa2 into master Aug 23, 2021
@LukeShu LukeShu deleted the lukeshu/derror branch August 23, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants