dlog: Defer sprintf to the final logger. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comes after i discovered that telepresence's root daemon can spend a lot of time formatting debug statements even when the log level is set to info. For large enough requests this has a considerable performance penalty |
josecv
force-pushed
the
josecv/dlog-performance
branch
from
8920571
to
c823eb8
Compare
This is intended to preserve CPU cycles that would otherwise be spent formatting messages that will never be logged (e.g. formatting debug messages when the log level is info) Signed-off-by: Jose Cortes <josecortes@datawire.io>
josecv
force-pushed
the
josecv/dlog-performance
branch
3 times, most recently
from
059f1f9
to
5c7357f
Compare
Signed-off-by: Jose Cortes <josecortes@datawire.io>
josecv
force-pushed
the
josecv/dlog-performance
branch
from
5c7357f
to
fef930a
Compare
LukeShu
added a commit
that referenced
this pull request
May 24, 2022
dlog: Fix issue where the fast-logging broke backward compat #28 changed the `Logger` interface, breaking any existing implementors of the interface. That's not OK. So revert that interface (and add a comment about how it's frozen), and add an opt-in `OptimizedLogger` interface for Jose's optimizations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to preserve CPU cycles that would otherwise be spent
formatting messages that will never be logged (e.g. formatting debug
messages when the log level is info)
Signed-off-by: Jose Cortes josecortes@datawire.io