Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Arithmetic coercion warning #212

Merged
merged 7 commits into from
Jul 7, 2016
Merged

Arithmetic coercion warning #212

merged 7 commits into from
Jul 7, 2016

Conversation

bozzzzo
Copy link
Contributor

@bozzzzo bozzzzo commented Jul 6, 2016

There are a few things in here:

  • Long literals are now of type long
  • Constructors must now match the name of the class
  • @deprecated is implemented for auto-coercion only
  • Errors and/or warnings are less likely dropped to the floor

@bozzzzo
Copy link
Contributor Author

bozzzzo commented Jul 7, 2016

An example of new warnings emitted:

/Users/bozzo/XLII/datawire/reactivesocket/tck/rxlib.q:57:9: warning: constructor name 'RequestResponse' does not match class name 'RequestServer'. Missing return type?
/Users/bozzo/XLII/datawire/reactivesocket/tck/rxlib.q:88:9: warning: constructor name 'RequestClient' does not match class name 'SimpleRequestClient'. Missing return type?
/Users/bozzo/XLII/datawire/reactivesocket/tck/rxlib.q:204:29: warning: Use of deprecated methodmacro '__to_int'. "Long used in integer context will silently truncate the result. Please use truncateToInt() or reverse the operands."
 done.

@rhs rhs merged commit 0b64d23 into develop Jul 7, 2016
@bozzzzo bozzzzo deleted the arithmetic-coercion-warning branch July 8, 2016 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants