This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Add floats to quark 2 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 5, 2016 11:17
rhs
reviewed
Dec 5, 2016
| try: | ||
| self.symbols.define(node) | ||
| except: | ||
| self.errors.add("Error at " + node.location) |
There was a problem hiding this comment.
Why the catchall? Is this necessary anymore?
| except QuarkError, e: | ||
| return e | ||
| except: |
There was a problem hiding this comment.
Same question about the catchall here.
rhs
reviewed
Dec 5, 2016
| @@ -439,6 +439,12 @@ def __call__(self, *args, **kwargs): | |||
| return compiled.apply(self.object, *args, **kwargs) | |||
| except MatchError, e: | |||
| raise TypeError("%s.%s() %s" % (self.clazz.__name__, self.dispatcher.name, e)) | |||
| except: | |||
There was a problem hiding this comment.
I think this catchall is also unnecessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.