-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved German and fr-CH formatLong #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe.skip
should be ditched before merge.
Please tell me if you need help with the PR. |
@kossnocorp You can continue the PR. I do not know the actual alpha state. |
@vanvuongngo what do you mean? I still see some |
@kossnocorp To remove the describe.skip it needs translations |
I see. So you're have no plans to continue work on the PR? I'm afraid that I can't continue working on it as I don't understand German. I can help only with code and guidance. |
@kossnocorp Glad to here you want to integrate my change. I had a look at the translation and removed the skips. |
Thank you a lot! It was released as |
formatLong L for German and fr-CH