Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: soft deps + catalog option #46

Merged
merged 5 commits into from
Sep 2, 2023
Merged

feat: soft deps + catalog option #46

merged 5 commits into from
Sep 2, 2023

Conversation

datnguye
Copy link
Owner

@datnguye datnguye commented Sep 2, 2023

resolves #45

  • Make top pin to <1.0.0
  • Add WARN to upgrade the package for new artifact version which not supported yet
  • Add -cv catalog version option

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #46 (fe5fa5e) into main (8458395) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines          883       895   +12     
=========================================
+ Hits           883       895   +12     
Files Changed Coverage Δ
dbterd/adapters/base.py 100.00% <100.00%> (ø)
dbterd/cli/params.py 100.00% <100.00%> (ø)
dbterd/helpers/file.py 100.00% <100.00%> (ø)
tests/unit/adapters/test_base.py 100.00% <100.00%> (ø)
tests/unit/helpers/test_file.py 100.00% <100.00%> (ø)

@datnguye datnguye changed the title feat: top pin dbt-artifiacts-parser to < 1.0.0 and better warning mes… feat: soft deps + catalog option Sep 2, 2023
@datnguye datnguye merged commit 2cb01ee into main Sep 2, 2023
12 checks passed
@datnguye datnguye deleted the feature/more-soft-deps branch September 2, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Make more soft-depends on dbt-artifacts-parsers
1 participant