Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create classes for Errors and Response #20

Closed
3 tasks done
hannelita opened this issue Jun 16, 2020 · 1 comment
Closed
3 tasks done

Create classes for Errors and Response #20

hannelita opened this issue Jun 16, 2020 · 1 comment
Assignees
Labels

Comments

@hannelita
Copy link
Contributor

hannelita commented Jun 16, 2020

Acceptance

  • Aircan lib code to be wrapped into a class file
  • Create default interface for errors
  • Create default interface for response

Tasks

At this time our internal libraries handle errors and responses this way, for example return {"success": False, "response": response.json()}.

Ideally, we should create a proper class for exceptions, errors handling and responses, unifying the way the system behaves (in library level)

@hannelita
Copy link
Contributor Author

#20 and #53 fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants