Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/test suite #51

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Bug/test suite #51

merged 2 commits into from
Jul 9, 2020

Conversation

hannelita
Copy link
Contributor

Relates to #50

This PR does not fix the test suite entirely.

  • This PR changes psycopg2 to psycopg2-binary (Issues with GCP and MacOS; we may investigate this in the future; but for now psycopg2 is not being used on aircan since we do not support postgres)
  • Fixes relative imports on tests
  • Skips tests related to postgres, since we do not support this mode yet

Some tests are still failing, see body of #50 for better description

@hannelita hannelita mentioned this pull request Jul 8, 2020
3 tasks
@shubham-mahajan shubham-mahajan merged commit ec89f05 into master Jul 9, 2020
Copy link
Member

@shubham-mahajan shubham-mahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged and will update more changes

@hannelita hannelita deleted the bug/test-suite branch July 9, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants