-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepending json version of csv resources causing unexpected behaviour in the frontend #4
Comments
Re your questions:
@rufuspollock - perhaps we need a third category here, for files that we want to keep both in original form and also extract the data out - although I'm not sure what exactly that process would look like for geojson. |
This order switch solves the problem with the first resource only. Indexes for other resources are // Original:
resources: [csv1, csv2]
// Transformed:
resources: [csv1, csv2, json1, json2] On the other hand, we could require publishers to always use resource name (now it is either name or index) to reference a resource so we don't need to care about indexes. |
@akariv we should not be adding the JSON version of resources to the resource list IMO. The derived files should:
This is something that probably needs a bit of thought and my inclination would be first option (not included) and we just use a convention to locate them for now. (Amongst other things these are not separate resources taht should should have a separate rendering in the frontend but just a conversion of a given resource to a different format). Aside: I think we may want _datahub as path rather than .datahub as directory name. What do people think. @akariv i guess this raises some interesting questions re pipelines and our setup here. In pipelines datapackage.json is being used as the manifest - so to add the json version involves adding a new resource. However, in terms of datapackage.json I don't think we want these derived files to show up as new resources. I think we probably need to think this through in some way asap. |
@rufuspollock I don't really follow. |
@akariv because the derived stuff is derived. From the presentation PoV these are not "real" resources - but simply different formatting of the original resource. There are different ways to look at this
There are lots of way we could think about implementing this - probably worth a chat. |
WONTFIX / INVALID. This is now no longer relevant since we switched to "extended" datapackage.json in the pkgstore. |
As I understood we're prepending
json
version of eachcsv
resource in a data package. However, inviews
property of a descriptor we reference resources using initial indexes. So now our0
resource is not expectedcsv
file butjson
version of it.Questions:
json
versions in the end ofresources
? So this way it would work as expected.json
(orgeojson
,topojson
etc.)?The text was updated successfully, but these errors were encountered: