Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get user profile #19

Merged
merged 3 commits into from
Aug 10, 2017
Merged

Get user profile #19

merged 3 commits into from
Aug 10, 2017

Conversation

anuveyatsu
Copy link
Member

API for getting user profile information: /auth/get_profile?username=<username>

  • new method get_profile_by_username in controllers
    • tests
  • blueprint

@anuveyatsu anuveyatsu requested a review from zelima August 10, 2017 08:16
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 72.561% when pulling 3ca33b7 on feature/get-user-profile into 92b85ad on master.

@rufuspollock
Copy link
Member

@anuveyatsu what issue does this relate to? Also what is the access restriction on this? And have you run it past @akariv ?

@akariv
Copy link
Collaborator

akariv commented Aug 10, 2017

Hmm... not sure what this is going to be used for.
Anyway I don't think we'd like to expose the email address of all users via an api, no?

@anuveyatsu
Copy link
Member Author

@akariv so probably we can expose some specific fields: username, userid, full name(?) and join_date. What do you think?

@akariv
Copy link
Collaborator

akariv commented Aug 10, 2017 via email

@anuveyatsu
Copy link
Member Author

anuveyatsu commented Aug 10, 2017

@akariv In the frontend, we want to show user profile information - joined_date (maybe some more in the future).

@akariv
Copy link
Collaborator

akariv commented Aug 10, 2017

Okay - so yes, let's select exactly the fields that we want to expose publicly and only these should be returned in the API.

@anuveyatsu
Copy link
Member Author

anuveyatsu commented Aug 10, 2017

@akariv @rufuspollock so I will have these fields exposed:

  • userid
  • join_date

Please, confirm.

UPDATE: I suppose this is already minimal fields so I assume it is confirmed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 72.561% when pulling 895ffd5 on feature/get-user-profile into 92b85ad on master.

@anuveyatsu anuveyatsu merged commit a03feac into master Aug 10, 2017
@anuveyatsu anuveyatsu deleted the feature/get-user-profile branch August 10, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants