Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case insensitive path #30

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Case insensitive path #30

merged 3 commits into from
Sep 5, 2018

Conversation

anuveyatsu
Copy link
Member

@anuveyatsu anuveyatsu commented Sep 5, 2018 •
edited
Loading

As reported in datahub-v2/frontend#102 we want to make case insensitive usernames. This PR includes 3 things:

  • when creating a user, we lowercase provided username
  • when getting a user by username, we compare values by lowercasing both provided value and value in the db
  • restored old tests

@coveralls
Copy link

Coverage Status

Coverage increased (+5.9%) to 74.599% when pulling 2d298be on feature/case-insensitive-path into 0e8dea7 on master.

zelima
zelima suggested changes Sep 5, 2018
View reviewed changes
Copy link
Collaborator

@zelima zelima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good and should work. Just see small comment for discussion

auth/models.py Show resolved Hide resolved
@anuveyatsu anuveyatsu merged commit ec58ae8 into master Sep 5, 2018
@anuveyatsu anuveyatsu deleted the feature/case-insensitive-path branch September 5, 2018 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zelima zelima zelima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuveyatsu @coveralls @zelima