Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4 Add support for generic action request to CKAN #14

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

kmanaseryan
Copy link
Contributor

No description provided.

@kmanaseryan kmanaseryan linked an issue Sep 14, 2020 that may be closed by this pull request
10 tasks
Copy link
Member

@rufuspollock rufuspollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

lib/index.js Show resolved Hide resolved
lib/index.js Show resolved Hide resolved

const response = await axios.post(`${this.api}${path}`, payload, config)
if (!response.data.success) {
throw `Action response: ${response.statusText}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'd probably want to include a bit more info but that is good ...

@rufuspollock rufuspollock merged commit c3605f4 into master Sep 14, 2020
@kmanaseryan kmanaseryan mentioned this pull request Sep 15, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[epic] v0.2 Development of the Client SDK
2 participants