-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editable Metadata for file (whilst uploading) and default values are inferred from supplied file (e.g. title ...) #12
Comments
…12 - skiped select file test for while
@rufuspollock please take a look at this gif below.
Object example:
My question is: each key of this object above needs to have a label and description?
|
- auto-populate with the information of the file - render a list of format - render a list of encode - be able to edit the metadata information when uploading the file
@mariorodeghiero great job 👏
No, you don't. If you want information about fields that should go in the profile / json schema which describes the form. For now I would be using an enhanced profile based of data resource json schema but with additional enums for e.g. format field. (if that does not make sense let's chat). Other comments
|
@rufuspollock ok, I will get a list of format and licenses and render it in select option. yes, I agree with you, we need to think about UX. I will try to add something like you said. |
@rufuspollock take a look. |
@mariorodeghiero looks good 👏 . I think we could auto start upload once file is selected (so no need for upload button) but that is very minor. Can we get this deployed at a staging site (maybe using storybook) so i can play around - this is #5 |
@rufuspollock right, I'm adding the licenses and I'll remove to use auto-upload and start to create the new stories. |
- add licenses json - add formats json - removed button upload - add auto-upload when selecet a file - enable save metadata button when the upload is done - render list of licenses - render list of formats - change the UI
there's no need for licenses (?) - these are resources we are editing.
…_________________________________________________________________________
*Datopian *| https://datopian.com | Open solutions for a data driven world
*DataHub* | https://datahub.io | GitHub for data
*CKAN * | http://ckan.org <https://ckan.org/> | The world's leading
data portal solution
President - +44 7795176976 - @rufuspollock
On Thu, Aug 20, 2020 at 7:33 PM Mário Antônio do Amaral Rodeghiero < ***@***.***> wrote:
@rufuspollock <https://github.com/rufuspollock> right, I'm adding the
licenses and I'll remove to use auto-upload and start to create the new
stories.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMDMQW4SXFHCXYSZF3VKLSBVM5DANCNFSM4P25CNZA>
.
|
@rufuspollock we're looking at "Bonus" part of this issue's Acceptance Criteria and it looks like it is related to #13
Could you confirm? |
@anuveyatsu confirmed and i've removed it. |
Fixed. |
@mariorodeghiero there was one item in the acceptance not ticked re labels. Can you comment on that in the acceptance section. Also in general can you update the acceptance section with brief comments on each item see https://playbook.datopian.com/issues-tasks/#completing-tasks for notes about that. (so not just ticking the checkbox but a short comment too in bold) Also are we running off json schema atm or is it hard-coded (the form)? |
The item below was not ticked. You can check why in this conversation
|
@mariorodeghiero i think we misunderstood each other in that discussion. I meant you don't need a label in what you save but you want a label / description in the form which come from the json schema (if we had that). Anyway at this point no big deal and we can leave this. |
When the user selects a file and starts uploading they are presented with key metadata fields (e.g.title, description, encode, and format) that they can edit. These metadata fields should be auto-populated where possible. The user can then explicitly save (once the file has finished uploading).
Bonus would be extracting the table schema info: I want to extract the table schema info from the file and save it in a JSON object.See #13Acceptance
Given a file by a user
Tasks
data.js
https://github.com/datopian/data.js to load the file and infer informationBonus
The text was updated successfully, but these errors were encountered: