Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated resource editor app in React #16

Closed
4 tasks done
rufuspollock opened this issue Aug 27, 2020 · 10 comments
Closed
4 tasks done

Integrated resource editor app in React #16

rufuspollock opened this issue Aug 27, 2020 · 10 comments
Assignees

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Aug 27, 2020

React App combining several lower level components into an app / flow: Upload, Edit metadata, Edit table schema, Save

Need to mock this up a bit.

  • Upload
  • Metadata editor
  • Schema editor

Could be stepped or all in one page (maybe hide show for some of it so it would work with multiple resources).

Acceptance criteria

  • I can use this app (with some config) to add new resources into a CKAN DMS

Tasks

  • Wire components together into an overall component
  • Mock up wireframe
  • Implement the wireframe
mariorodeghiero added a commit that referenced this issue Aug 27, 2020
…#16

- integrated all components
- refactor html semantic
- refactor css
- add stepper component
- add mockup for tableschema
@mariorodeghiero
Copy link
Contributor

@rufuspollock @anuveyatsu I sent a PR with some updates in this commit 9e0d670 you can see the result online in
https://datopian.github.io/datapub/?path=/story/templates--app-template

Tomorrow I pretend to improve more the save metadata and save schema process + stepper.

@anuveyatsu
Copy link
Member

@mariorodeghiero how about enabling multiple file uploads?

@rufuspollock
Copy link
Member Author

rufuspollock commented Aug 28, 2020 via email

@mariorodeghiero
Copy link
Contributor

@anuveyatsu @rufuspollock Can be controlled for each file independently?
I thought in some like: when the user selects the file uploaded/uploading. The "Editor stepper" will show only the info about the file selected and the user can edit it.

@anuveyatsu
Copy link
Member

@mariorodeghiero I think you mean the same thing as Rufus 😄 anyway let's leave the multiple files for later

@mariorodeghiero
Copy link
Contributor

sounds good, let's keep with the plan

@mariorodeghiero
Copy link
Contributor

@anuveyatsu @rufuspollock could please take a look https://datopian.github.io/datapub/?path=/story/templates--app-template if need something more for this issue?

I think the next step we need to fix. If hasn't a schema for the current file, we need to create a default schema?

@anuveyatsu
Copy link
Member

@mariorodeghiero I'm not sure if there is a schema when user just uploads a file. I believe the steps are:

  1. Select a file for upload
  2. The app detects title and format (if possible)
  3. It infers schema from the given file (assuming it's tabular)
  4. Now, user can change metadata and/or schema

cc @rufuspollock

mariorodeghiero added a commit that referenced this issue Aug 31, 2020
- Now is possible to click in showInfo and see the component documentation
@mariorodeghiero
Copy link
Contributor

added some documentation improvements, now you can click in "Docs" (in the top left) and see the documentation of the components and all status of the stories.

Screenshot from 2020-08-31 11-48-34

@rufuspollock
Copy link
Member Author

FIXED. We have this wired up pretty nicely now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants