-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resource] Upload or Link Chooser #18
Comments
- add tests - update readme - refactor the upload component - refactor to create InputFile component - refactor to create InputUrl component - add stories in the storybook for InpuFile and InputUrl component - edit css to add the chooser upload method
@kmanaseryan I did some improvements adding:
|
@mariorodeghiero I suggest we use figma to illustrate flow here if poss at the start so we get clear.
|
@rufuspollock is a question. |
Guys maybe this sounds odd question, but is it possible for the users to do both? I mean upload file and also add link to file |
I'm creating a Figma to illustrate it as Rufus' idea. I will share it here... |
No. |
Sounds good. I meant if technically it is possible then maybe it's better to show both fields, but make required to pick at least one. |
@rufuspollock To extract the information(title and format) from the URL. Do we will use some specific library or can I do this using Regex? |
@mariorodeghiero you should use data.js - that's the plan ... |
@mariorodeghiero remember this issue is just about the chooser - not about implementing the link option ... (that should be a separate issue and is likely dependent on data.js ...) |
great! |
- add choose componet - add stories for each component Choose, InputFile, InputUrl - change Utils test file name
- add choose componet - add stories for each component Choose, InputFile, InputUrl - change Utils test file name - fix estlint
@rufuspollock @kmanaseryan I created a simple choose component. Now the user can choose what type of upload. If the type is an URL when the user left the focus or click enter, will send an event with the value. |
Great. When you type something in the url component and it loses focus we
should bring up metadata editor and schema editor with info filled in if we
can (but this should be a separate issue for creating a LinkFile component
...)
…_________________________________________________________________________
*Datopian *| https://datopian.com | Open solutions for a data driven world
*DataHub* | https://datahub.io | GitHub for data
*CKAN * | http://ckan.org <https://ckan.org/> | The world's leading
data portal solution
President - +44 7795176976 - @rufuspollock
On Thu, Sep 3, 2020 at 12:48 AM Mário Antônio do Amaral Rodeghiero < ***@***.***> wrote:
@rufuspollock <https://github.com/rufuspollock> @kmanaseryan
<https://github.com/kmanaseryan> I created a simple choose component. Now
the user can choose what type of upload. If the type is an URL when the
user left the focus or click enter, will send an event with the value.
In the gif below I show how it works sending a console.log with the input
URL value.
[image: url]
<https://user-images.githubusercontent.com/24671133/92044711-3aa33900-ed55-11ea-8713-3df8bc3c1be4.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMDMWZKR6FSDFAF4PX32LSD3DVRANCNFSM4QSB5ASQ>
.
|
@mariorodeghiero can we now close this? |
FIXED. Now the user can choose what type of upload. If the type is an URL when the user left the focus or click enter, will send an event with the value.
|
When the user uploads an open upload app, the user wants to choose it is a file or link.
Acceptance
* [ ] The metadata will infer the user to choose a link (?)Tasks
* [ ] JS/UI - After the user chooses an upload link and insert a link.- Does the metadata should be auto-populate like already happens with the upload a file?Bonus:
The text was updated successfully, but these errors were encountered: