Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload progress reporting #9

Closed
5 tasks done
lgilies opened this issue Aug 11, 2020 · 5 comments
Closed
5 tasks done

File upload progress reporting #9

lgilies opened this issue Aug 11, 2020 · 5 comments
Assignees

Comments

@lgilies
Copy link

lgilies commented Aug 11, 2020

When the user uploads a file to the storage the upload progress expects to be tracked showing a progress bar to the user with percentage done, time remaining and kb/s sec.

Acceptance

  • I can track the progress when uploading the file to the blog storage
  • Show a circular progress bar to the user with time remaining and percentage done and kb/s sec.

Tasks

  • UI - Create a circular progress bar
  • JS - Track the progress and populate the progress bar
  • JS/UI - Show percentage done, time remaining and kb/s sec
@mariorodeghiero mariorodeghiero self-assigned this Aug 11, 2020
mariorodeghiero added a commit that referenced this issue Aug 13, 2020
- add circular progress
- add percentage in the middle of the circle
- show time remainining in seconds or minutes
- add PropTypes for components
- edit css styles
@mariorodeghiero
Copy link
Contributor

mariorodeghiero commented Aug 13, 2020

@rufuspollock I did some changes in this commit the result you can see in the picture below.

Tomorrow I pretend to review these changes and keep working.
Screenshot from 2020-08-12 21-12-44

@rufuspollock
Copy link
Member

@mariorodeghiero this is great!

mariorodeghiero added a commit that referenced this issue Aug 14, 2020
- change layout style to improve UI
- add more information about the upload and file to show to user
- add drag and drop area
- add a list of files uploading
- add name of the file with overflow
- add function convert bytes in KB, MB, GB
- add test to cover the onFormatBytes
@mariorodeghiero
Copy link
Contributor

@rufuspollock Check the gif below, please. I did some changes here, do you think is necessary to show kb/s?

Note: I throttling my internet to "3G" to upload the file.
upload

@rufuspollock
Copy link
Member

@mariorodeghiero no, time remaining is great - don't think we need kb/s atm.

BTW luurve ❤️ the gif - so great for understanding the feature 👏

I think you can close.

@mariorodeghiero
Copy link
Contributor

Thanks, and yes! I agree with you.

FIXED.

  • UI - Create a circular progress bar
  • JS - Track the progress and populate the progress bar
  • JS/UI - Show percentage done, time remaining and kb/s sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants