-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[][m]: Implement hot-reloading #620
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start and I would definitely use this package as well. But we also need a way to re-index changed files (to get current metadata) and index new ones (so that they can be rendered at all). Fortunately, this package allows for running custom scripts on change/add/delete/... events with --script
flag! And the cool thing is that the script will be passed the event type as an argument, so in the future we could use it to only index/re-index/delete single files. For now, let's just re-index the whole folder on any type of the event. Then you can try implementing it the right way.
An issue with the library is preventing me from using the --command flag
I also cannot use
|
@mohamedsalem401 Just please make sure the E2E tests are passing and we can merge. |
For #587
content
folder.next-remote-watch