Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universes and members should be locateable by relative paths. #16

Closed
dotsdl opened this issue Mar 19, 2015 · 4 comments
Closed

Universes and members should be locateable by relative paths. #16

dotsdl opened this issue Mar 19, 2015 · 4 comments
Assignees
Milestone

Comments

@dotsdl
Copy link
Member

dotsdl commented Mar 19, 2015

At the moment, Universes and Members use only stored absolute paths for finding the files they need to generate universes and members, respectively. Relative paths from the Container's basedir are also stored, but they are not yet used. This breaks functionality for Sims and Groups when moving them around in a filesystem, even when the relative paths between these Containers and the files they require haven't changed.

The relative paths should be tried in the event the absolute path fails. If the file is found, the absolute path should be updated.

@dotsdl dotsdl self-assigned this Mar 19, 2015
@dotsdl dotsdl added this to the 0.5.0 milestone Mar 19, 2015
@dotsdl
Copy link
Member Author

dotsdl commented Mar 30, 2015

Eventually, the MDSynthesis.core.filesystem.Foxhound object will be used to sniff out missing members of Groups, but we shouldn't need to invoke it if such members can already be found by the Group with the information it already has.

@dotsdl
Copy link
Member Author

dotsdl commented Apr 1, 2015

Been hacking on this today, and after some significant changes to the GroupFile and Members aggregator it's become clear that a reasonable solution practically requires Foxhound to be implemented at a basic level before this issue can be resolved. I think this should happen before the 0.5.0 release, too, so the release might need pushing back.

@dotsdl
Copy link
Member Author

dotsdl commented May 18, 2015

Finally finished (mostly) an overhaul of Group.Members and Bundle that includes automatic hunting and finding of Containers that have moved. The Foxhound object handles the details of this filesystem search. After I add some explicit tests of this work I'll merge it into develop.

@dotsdl
Copy link
Member Author

dotsdl commented May 19, 2015

Merged into master the work that makes Group members locateable automatically by relative paths, as well as some brief period of searching if they can't be found. Still need to include a bit of code in Foxhound to make relative paths usable by Sim to find topologies/trajectories.

@dotsdl dotsdl closed this as completed in 6dc5bee Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant