This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
feat: exclude paths regex #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Meyazhagan Thank you for raising this PR 🤩 We will review it in the upcoming days |
royhadad
suggested changes
May 8, 2023
pkg/fileReader/reader.go
Outdated
| var filePaths []string | ||
|
|
||
| excludeRe, err := regexp.Compile(excludePattern) |
There was a problem hiding this comment.
This is good, but missing a more explicit validation in:
Line 96 in 5daac43
the error message can be: "invalid --exclude flag: <THE_ERROR>"
| @@ -55,16 +56,22 @@ func CreateFileReader(opts *FileReaderOptions) *FileReader { | |||
| return fileReader | |||
| } | |||
|
|
|||
| func (fr *FileReader) FilterFiles(paths []string) ([]string, error) { | |||
| func (fr *FileReader) FilterFiles(paths []string, excludePattern string) ([]string, error) { | |||
There was a problem hiding this comment.
please add some unit tests, I suggest starting with reader_test.go :)
pkg/fileReader/reader.go
Outdated
| var filePaths []string | ||
|
|
||
| excludeRe, err := regexp.Compile(excludePattern) |
There was a problem hiding this comment.
just a suggestion :)
Suggested change
| excludeRe, err := regexp.Compile(excludePattern) | |
| excludeRegex, err := regexp.Compile(excludePattern) |
royhadad
reviewed
May 8, 2023
cmd/test/main.go
Outdated
| @@ -262,6 +265,7 @@ func (flags *TestCommandFlags) AddFlags(cmd *cobra.Command) { | |||
|
|
|||
| cmd.Flags().StringVarP(&flags.K8sVersion, "schema-version", "s", "", "Set kubernetes version to validate against. Defaults to 1.24.0") | |||
| cmd.Flags().StringVarP(&flags.PolicyName, "policy", "p", "", "Policy name to run against") | |||
| cmd.Flags().StringVarP(&flags.ExcludePattern, "exclude", "", "", "Exclude paths pattern") | |||
There was a problem hiding this comment.
Suggested change
| cmd.Flags().StringVarP(&flags.ExcludePattern, "exclude", "", "", "Exclude paths pattern") | |
| cmd.Flags().StringVarP(&flags.ExcludePattern, "exclude", "", "", "Exclude paths pattern (regex)") |
|
requested some minor changes, should be pretty straight forward :) |
|
@royhadad I have made the changes. Take a look ! |
|
@Meyazhagan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues - #732