Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified and hid the logic of creating URLs in controllers #5

Merged
merged 2 commits into from Jun 15, 2020
Merged

Simplified and hid the logic of creating URLs in controllers #5

merged 2 commits into from Jun 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2020

I found a problem in some cases with the default budget. I fixed them by further simplifying the way URLs are built and hiding most of the nasty logic in private functions inside BaseController.

Also I gave UserController some love by inheriting BaseController :))

@ghost
Copy link
Author

ghost commented May 18, 2020

@dauby88 I always promise it's the last one but let's hope this is the last one :)) it's related to the 'default' budget.

@dauby88 dauby88 merged commit d5fb5c8 into dauby88:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant