Feature/test #2
Feature/test #2
Conversation
There was a problem hiding this comment.
STATUS: Changes Required ♻️
@daudi13 ✋🏼
Your project is great. You are almost done. However, there are some issues you should fix. Please fix them then your project will be approved.
♻️ Request changes ♻️
- Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
- Your commit messages should always start with capital letters and they should be an imperative tense. I see some of them are not like that. Instead of writing
Added style or Created the fileyou should writeAdd style or Create the file - I write it as optional. But this is a general requirement for every project. So you should pay attention to this in your next projects.
OPTIONAL
- You can change them by using
git-rebase. If you want to know how to change ı leave a few resources. - Video - How to change commit messages
- Article - How to create good commit messages
Cheers and Happy coding! 💻 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Reviewed by Ahmet Bozacı
|
@ahmetbozaci Thank you for your review, can you provide us with clarity what are the things that we are supposed to change? |
Hello sorry ı think ı didn't save the comment
|
There was a problem hiding this comment.
Hi, @BonkeGcobo & @daudi13,
You've done well addressing concerns from the previous review 👏🏼.
Tasks for this project are now successfully implemented 💯.
Highlights
- Professional README ✔️
- Clean code ✔️
- Good commit messages ✔️
All the best with the next project.
You are free to merge this branch 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description
Thank you