Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mime type guessing #121

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Fix Mime type guessing #121

merged 1 commit into from
Aug 8, 2019

Conversation

danielskeenan
Copy link
Contributor

Fixes #119

@danielskeenan
Copy link
Contributor Author

I left the deprecated usage of \Symfony\Component\HttpFoundation\File\MimeType\MimeTypeGuesserInterface in because I can't tell if anything else internally depends on that interface. Implementing the replacement interface fixes the referenced issue.

@onigoetz
Copy link
Contributor

onigoetz commented Aug 8, 2019

Oh thank you so much for the PR, I didn't have time to look into it.

I will try to add a test to make sure this doesn't break again

@onigoetz onigoetz merged commit a17b3d7 into dauxio:master Aug 8, 2019
onigoetz added a commit that referenced this pull request Aug 8, 2019
@onigoetz
#121 Add tests to make sure it doesn't break again
61eaad4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

daux serve doesn't work with custom themes
2 participants
@danielskeenan @onigoetz