Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM.setAttribute: add hidden to boolean attributes #53

Merged
merged 1 commit into from
Jan 7, 2022
Merged

DOM.setAttribute: add hidden to boolean attributes #53

merged 1 commit into from
Jan 7, 2022

Conversation

PierreYvesR
Copy link
Contributor

This started when I tried to use

Bind.attr("hidden", model .> (fun m -> m.DisplayedPage <> pageValue) |> Store.distinct)

@AngelMunoz
Copy link
Contributor

Oh yeah this one was kind of covered by #34 but it seems it never got revisited, Bind.attr binds to JS properties not Element attributes not sure if you want to revisit that @davedawkins

@davedawkins davedawkins merged commit 0b96053 into davedawkins:main Jan 7, 2022
@davedawkins
Copy link
Owner

Thanks for this!
@AngelMunoz I haven't forgotten about #34, thanks for reminding me though

@PierreYvesR PierreYvesR deleted the hiddenAttribute branch January 7, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PierreYvesR @AngelMunoz @davedawkins