Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other Postgres relevant Sequelize options #32

Closed
25 tasks done
davesag opened this issue Apr 20, 2019 · 4 comments
Closed
25 tasks done

Support other Postgres relevant Sequelize options #32

davesag opened this issue Apr 20, 2019 · 4 comments
Assignees
@davesag
Labels
feature
Milestone
Version 1.3.0

Comments

@davesag
Copy link
Owner

davesag commented Apr 20, 2019 •
edited
Loading

Sequelize supports a wide range of options that this utility ignores. Go through them, work out which ones are supported by Postgres and allow them to be used.

programatic only options

Can only be set by passing in as an option to Sequelize via

const sequelize = new Sequelize('database', 'username', 'password', options);
  • dialectModule
  • dialectModulePath
  • define
  • query
  • schema
  • set
  • sync
  • pool.validate
  • quoteIdentifiers
  • transactionType
  • retry.match
  • retry.max
  • typeValidation
  • hooks

config options

Can be defined in config file.

  • protocol
  • timezone
  • clientMinMessages
  • benchmark
  • omitNull
  • native
  • replication
  • pool.acquire
  • pool.evict

environment variable options

Can be defined as an environment variable

  • DB_POOL_ACQUIRE ie pool.acquire
  • DB_POOL_EVICT ie pool.evict

omiting any of these options means they are omitted from the final config object.
@davesag davesag modified the milestones: Version 1.2, Version 1.2.1 Apr 20, 2019
@davesag davesag changed the title Support all the other sequelize options Support other Postgres relevant Sequelize options Apr 21, 2019
@davesag davesag added the work in progress Someone is doing something about it label Apr 21, 2019
@davesag davesag modified the milestones: Version 1.2.1, Version 1.2.2 May 4, 2019
@davesag davesag removed the work in progress Someone is doing something about it label Jun 24, 2019
@adlenafane
Copy link

We'd love to have the pool.acquire option @hiboo.io. Could I help you on this topic?

davesag added a commit that referenced this issue Feb 5, 2020
@davesag
#32 support optional environment variables
6abf2a6
@davesag
Copy link
Owner Author

davesag commented Feb 5, 2020

Hey @adlenafane

We'd love to have the pool.acquire option @hiboo.io. Could I help you on this topic?

I have added this in PR #67

Please have a look and let me know if this works for you.

@davesag davesag self-assigned this Feb 7, 2020
davesag added a commit that referenced this issue Feb 7, 2020
@davesag
Merge pull request #67 from davesag/feature/32/support-additional-env…
6213503 
…ironment-variables

[feature, #32] support optional environment variables
@davesag
Copy link
Owner Author

davesag commented Feb 7, 2020

@adlenafane support for pool.acquire and pool.evict have been added to Version 1.2.4 - released to NPM a few minutes ago. Thanks for your input.

davesag added a commit that referenced this issue Feb 7, 2020
@davesag
#32 support additional options
7eda8fc
davesag added a commit that referenced this issue Feb 7, 2020
@davesag
Merge pull request #68 from davesag/feature/32/add-programmatic-options
c8b2fab 
[feature, #32] support additional options
davesag added a commit that referenced this issue Feb 9, 2020
@davesag
#32 added final config options
c397670
davesag added a commit that referenced this issue Feb 9, 2020
@davesag
#32 added config
849883f
davesag added a commit that referenced this issue Feb 9, 2020
@davesag
Merge pull request #69 from davesag/feature/32/additional-config-options
5df3be3 
[feature, #32] added final config options
@davesag davesag closed this as completed Feb 9, 2020
@davesag
Copy link
Owner Author

davesag commented Feb 9, 2020

Implemented in version 1.3.0

davesag added a commit that referenced this issue Feb 9, 2020
@davesag
#32 slight improvement to docs
e41333c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davesag davesag

Labels
feature
Projects
None yet
Milestone
Version 1.3.0
Development

No branches or pull requests
2 participants
@davesag @adlenafane